feat: support webpack 2.4 chunk name annotation for "async-import"#9
Open
pglazkov wants to merge 2 commits intoshlomiassaf:ASTfrom
pglazkov:AST
Open
feat: support webpack 2.4 chunk name annotation for "async-import"#9pglazkov wants to merge 2 commits intoshlomiassaf:ASTfrom pglazkov:AST
pglazkov wants to merge 2 commits intoshlomiassaf:ASTfrom
pglazkov:AST
Conversation
|
This would be wonderful to have. @shlomiassaf Is this project still being supported? |
Author
|
@shaungrady As an alternative you might want to try angular-named-lazy-chunks-webpack-plugin - it automatically generates chunk names based on the module names, so you don't need to add any annotations in code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since version 2.4 Webpack supports annotating
import()calls with the name of the chunk:This pull request adds the implementation of adding that annotation comment if the "chunkName" option is provided as part of the route, like so:
loadChildren: 'app/module-container/child-module#ChildModule?chunkName=my-chunk-name'